Allow to create workspace#701
Merged
jcarpent merged 14 commits intojrl-umi3218:masterfrom Jul 24, 2024
Merged
Conversation
…that contains jrl-cmakemodule
…t_finalize must be run automatically
for more information, see https://pre-commit.ci
Collaborator
|
Thanks for this work ! |
Contributor
Author
|
I will push similar PR on:
I will also create a new repository called simple-robotics/workspace that will store the root CMakelists.txt and probably some scripts to populate the workspace. |
Contributor
Author
|
I keep this PR as a draft until I'm sure all modified project still build in standalone mode in the CI. |
Contributor
Author
|
@nim65s If you want to test it, I have uploaded the workspace repository. If the README.md is hard to understand or you encounter some issues please add some comment in this PR |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to allow project using jrl-cmakemodules to be used under the same root CMakeLists.txt (workspace).
PROJECT_PACKAGES_IN_WORKSPACEthat should avoid running find_package inADD_PROJECT_DEPENDENCYandADD_PROJECT_PRIVATE_DEPENDENCYon project already in the workspaceADD_PROJECT_PRIVATE_DEPENDENCYthat check forPROJECT_PACKAGES_IN_WORKSPACEbefore calling find_packagePROJECT_PYTHON_PACKAGES_IN_WORKSPACEto include Python modules from workspace inPYTHONPATHPROJECT_SOURCE_DIRandPROJECT_BINARY_DIRinstead ofCMAKE_SOURCE_DIRandCMAKE_BINARY_DIRsince thedistanddoctarget is working with multiple project butdistcheckis not working. Sincedistcheckdo some very heroic thing with the CMakeCache.txt, I don't think we can make it work for multiple project.